Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(msrv): set to 1.70 #469

Merged
merged 1 commit into from
May 9, 2024

Conversation

0x61nas
Copy link
Contributor

@0x61nas 0x61nas commented Mar 8, 2024

It will be helpful for the down stream crates to know what the minimum supported Rust version (MSRV) for their dependencies so they can decide how to bump their version and when, because it's considered as a breaking change

@kwinz
Copy link
Contributor

kwinz commented Mar 10, 2024

I am not sure why the CI test results are not showing for the branch here? I believe a maintainer merged a pull request changing the workflow file about a month ago, but the changes to the config weren't approved after merging them. Apparently the integration tests are still being run with the old config, but the results aren't showing up in the pull requests because of the missing approval. Can the maintainers please approve the continuous integration workflow config changes (or revert them)?
I can see that the tests are already failing so bugs or coding issues have probably already made it into the release unnoticed!

@Billy-Sheppard Billy-Sheppard merged commit 609d576 into rust-headless-chrome:main May 9, 2024
0 of 3 checks passed
@0x61nas 0x61nas deleted the chore/msrv branch May 9, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants