Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method for adding manually opened tabs #421

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

Asthowen
Copy link
Contributor

This PR adds a method for saving tabs that have been opened manually, the tabs are added to the right place in the list.

@Asthowen
Copy link
Contributor Author

Hello, are you interested in this PR (to find out if it's useful for me to resolve conflicts or not)?

@mdrokz
Copy link
Collaborator

mdrokz commented Feb 23, 2024

Hello, are you interested in this PR (to find out if it's useful for me to resolve conflicts or not)?

Hi sorry for the late reply i will review this today can you resolve the conflicts ?

@Asthowen
Copy link
Contributor Author

Hello, thanks for your quick reply, I've just resolved the conflicts.

Copy link
Collaborator

@mdrokz mdrokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for your contribution

@mdrokz mdrokz added the enhancement New feature or request label Feb 26, 2024
@mdrokz mdrokz merged commit a96db60 into rust-headless-chrome:main Feb 26, 2024
0 of 3 checks passed
@kwinz
Copy link
Contributor

kwinz commented Mar 10, 2024

@mdrokz LGTM on a pull request where the tests failed (X next to commit id)?

@Asthowen
Copy link
Contributor Author

It's not because of this PR that the tests are failing - they were failing before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants