Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deps, fixed CI commands, fixed clippy lints #419

Merged
merged 6 commits into from Oct 9, 2023
Merged

Updated deps, fixed CI commands, fixed clippy lints #419

merged 6 commits into from Oct 9, 2023

Conversation

Billy-Sheppard
Copy link
Collaborator

Supersedes #378

@Billy-Sheppard Billy-Sheppard marked this pull request as draft October 9, 2023 01:18
@Billy-Sheppard
Copy link
Collaborator Author

Draft PR as it compiles and passes tests but I haven't tested in a proper codebase/environment.

@Billy-Sheppard Billy-Sheppard marked this pull request as ready for review October 9, 2023 02:45
@Billy-Sheppard
Copy link
Collaborator Author

Now tested it works in my test environments. Should be gtg.

mdrokz
mdrokz approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@mdrokz mdrokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM! thanks for fixing the tests & updating the deps i was actually fixing the tests locally but wasnt getting any time.

@mdrokz mdrokz added the enhancement New feature or request label Oct 9, 2023
@mdrokz mdrokz merged commit d5abc01 into rust-headless-chrome:main Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrokz mdrokz mdrokz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Billy-Sheppard @mdrokz