Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_attribute_value() for Element #411

Merged
merged 1 commit into from Aug 27, 2023
Merged

Add get_attribute_value() for Element #411

merged 1 commit into from Aug 27, 2023

Conversation

CrendKing
Copy link
Contributor

Seemingly a quintessential function for an Element object, and there is indeed people asking for it, and chromiumoxide implements it.

mdrokz
mdrokz approved these changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@mdrokz mdrokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mdrokz mdrokz merged commit 213c7e4 into rust-headless-chrome:main Aug 27, 2023
1 check failed
@CrendKing CrendKing deleted the attr branch August 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrokz mdrokz mdrokz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrendKing @mdrokz