Fix detecting msedge.exe in Windows when Chrome is not found through registry #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! Thanks. |
pull bot
pushed a commit
to mirsella/rust-headless-chrome
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have Chrome installed, but Edge exists by default. When I do
println!("{}", headless_chrome::browser::default_executable());, it tells me "Could not auto detect a chrome executable".The related msedge.exe detection code seems wrong, because 1) it doesn't use
pathfrom the enclosing if let, and 2) msedge should be only needed if chrome is not detected, but the current code only does it otherwise.