Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic tab creation on launching chrome #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dimchee
Copy link

@dimchee dimchee commented Jul 31, 2023

It is useful to launch chrome directly with <url> (or --app=<url>) as argument, if you use headful browser.
Not opening empty tab is essential for simple neovim plugin I am developing.
It would be nice too if --app=<url> option was part of LaunchOptions.
I have seen that others had same issue as me, so this fixes #392.

Disable automatic tab creation on launching chrome
@Billy-Sheppard
Copy link
Collaborator

This seems reasonable to me. What do you think @mdrokz?

@mdrokz
Copy link
Collaborator

mdrokz commented Oct 9, 2023

This seems reasonable to me. What do you think @mdrokz?

Hey didnt get time to review this but this comment #392 (comment) seems to be concerning since it might be breaking get_tabs method can you check this and let me know @Billy-Sheppard thanks ?

@Billy-Sheppard
Copy link
Collaborator

Might have to be behind a flag, I can look at it in-environment soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to avoid opening a tab when connecting to existing browser
3 participants