Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added installation latest version of chrome and refactored fetcher #380

Merged
merged 2 commits into from Feb 22, 2023

Conversation

initprism
Copy link
Contributor

Fixed fetcher as discussed in
#374 (comment) and #374 (comment)

Now Revision::Latest gets the revision and installs the latest version of Chrome on that platform.

e.g

// let revision = headless_chrome::Revision::Specific("634997".into());
let revision = headless_chrome::Revision::Latest;
let fetcher_options = headless_chrome::FetcherOptions::default()
    .with_revision(revision);

let launch_options = headless_chrome::LaunchOptionsBuilder::default()
    .fetcher_options(fetcher_options)
    .build()?;

let browser = Browser::new(launch_options)?;

@mdrokz
Copy link
Collaborator

mdrokz commented Feb 22, 2023

Looks good thanks for your contribution @initprism !

@mdrokz mdrokz merged commit 284754b into rust-headless-chrome:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants