Cache Attributes, Tag Name and Value on Element creation

[masc-it]

Generally, we want to access an Element attributes and basic props when we create it, so why calling get_attributes() when we can already cache useful dom information, during the same Element instantation? I found out that it is literally a zero cost operation.

Also

• get_attributes() calls get_description() which has a depth of 100
• From my experiments, on long and complex pages it saves a lot of overhead (even couple of seconds per page)

Open point for another time

• Why do el.get_description() and tab.describe_node() have a depth of 100? Maybe we can parametrize it

[Billy-Sheppard]

This seems sensible, thanks!

As for your last point I don't have any direct familiarity with those methods - but I don't see any reason why they can't take a parameter - perhaps its worth adding this functionality as a new method as not to break API - something like get_description_with_depth(&self, depth: Option<usize>) -> Result<DOM::Node> {}

[mdrokz]

This seems sensible, thanks!

As for your last point I don't have any direct familiarity with those methods - but I don't see any reason why they can't take a parameter - perhaps its worth adding this functionality as a new method as not to break API - something like get_description_with_depth(&self, depth: Option<usize>) -> Result<DOM::Node> {}

This makes sense as well to ensure API compatibility otherwise everything looks good. @Billy-Sheppard you can merge this if you want