Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derive(Debug) and tracing logging #375

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Add derive(Debug) and tracing logging #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac71de
derive(Debug) for FetcherOptions & LaunchOptions
elpiel Oct 2, 2022
81f57f8
process - add trace for CLI arguments
elpiel Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const PLATFORM: &str = "mac";
#[cfg(windows)]
const PLATFORM: &str = "win";

#[derive(Clone)]
#[derive(Clone, Debug)]
pub struct FetcherOptions {
/// The desired chrome revision.
///
Expand Down
4 changes: 3 additions & 1 deletion src/browser/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl Drop for TemporaryProcess {

/// Represents the way in which Chrome is run. By default it will search for a Chrome
/// binary on the system, use an available port for debugging, and start in headless mode.
#[derive(Builder)]
#[derive(Debug, Builder)]
pub struct LaunchOptions<'a> {
/// Determines whether to run headless version of the browser. Defaults to true.
#[builder(default = "true")]
Expand Down Expand Up @@ -371,6 +371,8 @@ impl Process {
.ok_or_else(|| anyhow!("Chrome path required"))?;

info!("Launching Chrome binary at {:?}", &path);
trace!("with CLI arguments: {:?}", args);

let mut command = Command::new(path);

if let Some(process_envs) = launch_options.process_envs.clone() {
Expand Down