Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser sync #293

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Browser sync #293

merged 4 commits into from
Feb 16, 2022

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Feb 14, 2022

Closes #291

Also fixes the fetcher module (feature = "fetch"), as failure doesn't seem to be used anymore + a few other problem that came up.

Copy link
Collaborator

@mdrokz mdrokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks for your contribution.

src/browser/transport/mod.rs Outdated Show resolved Hide resolved
@elpiel
Copy link
Contributor Author

elpiel commented Feb 16, 2022

I've changed the buffer size for both channels.

There is also a test I can commit that checks that Browser is Sync. Let me know if you want me to commit it.

@mdrokz
Copy link
Collaborator

mdrokz commented Feb 16, 2022

I've changed the buffer size for both channels.

There is also a test I can commit that checks that Browser is Sync. Let me know if you want me to commit it.

Sure you can commit it.

@mdrokz mdrokz merged commit c1c8786 into rust-headless-chrome:master Feb 16, 2022
@mdrokz mdrokz linked an issue Feb 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloning Browser and using a mpsc::SyncSender Automatic chrome download does not seem to work?
2 participants