Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to avoid opening a tab when connecting to existing browser #392

Open
erkannt opened this issue May 9, 2023 · 3 comments · May be fixed by #405
Open

How to avoid opening a tab when connecting to existing browser #392

erkannt opened this issue May 9, 2023 · 3 comments · May be fixed by #405

Comments

@erkannt
Copy link

erkannt commented May 9, 2023

When I connect to an already open browser I always get a new tab.

Browser::connect(debug_ws_url)

Is this expected? Can I avoid it?
@dimchee
Copy link

dimchee commented Jul 31, 2023

Tab opening on new chrome instance is hardcoded, I am making PR to solve it, hopefully it will be accepted

@dimchee dimchee linked a pull request Jul 31, 2023 that will close this issue
Open
@dimchee
Copy link

dimchee commented Jul 31, 2023

You can try using my branch, by adding this to your Cargo.toml

[dependencies]
headless_chrome = { git = "https://github.com/dimchee/rust-headless-chrome.git" }

@erkannt
Copy link
Author

erkannt commented Aug 21, 2023

You can try using my branch, by adding this to your Cargo.toml

[dependencies]
headless_chrome = { git = "https://github.com/dimchee/rust-headless-chrome.git" }

I've tried your branch. It avoids the creation of the empty tab upon connection, however it seems to break get_tabs() for me. Even though the browser contains an open tab I am getting an empty Vec back.

erkannt/meetctl@main...spike/try-dimchee-empty-tab-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable automatic tab creation on launching chrome dimchee/rust-headless-chrome
2 participants
@erkannt @dimchee