Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support kv_unstable #294

Closed
wants to merge 1 commit into from
Closed

support kv_unstable #294

wants to merge 1 commit into from

Conversation

SVilgelm
Copy link

@SVilgelm SVilgelm commented Jan 9, 2024

Print the kev and values from a record if kv_unstable feature enabled

@SVilgelm
Copy link
Author

SVilgelm commented Jan 9, 2024

I'm aware of the #137, but that one is really outdated and I decided to write simpler solution

Print the kev and values from a record if `kv_unstable` feature enabled
visited: bool,
}

impl<'kvs> kv::Visitor<'kvs> for KVVisitor {

Check failure

Code scanning / clippy

implicit elided lifetime not allowed here Error

implicit elided lifetime not allowed here
visited: bool,
}

impl<'kvs> kv::Visitor<'kvs> for KVVisitor {

Check failure

Code scanning / clippy

implicit elided lifetime not allowed here Error

implicit elided lifetime not allowed here
fmt: self,
visited: false,
};
record.key_values().visit(&mut visitor)?;

Check failure

Code scanning / clippy

? couldn't convert the error to std::io::Error Error

? couldn't convert the error to std::io::Error
fmt: self,
visited: false,
};
record.key_values().visit(&mut visitor)?;

Check failure

Code scanning / clippy

? couldn't convert the error to std::io::Error Error

? couldn't convert the error to std::io::Error
@tmccombs
Copy link
Contributor

This is actually pretty similar to what I originally had in #137. But due to some other comments I added support for putting the key/value pairs on multiple lines, and putting it at the end instead of the beginning.

@SVilgelm SVilgelm closed this Jan 30, 2024
@SVilgelm SVilgelm deleted the kv_unstable branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants