-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.56.1 #693
Bump MSRV to 1.56.1 #693
Conversation
Should also update clippy.toml and both READMEs. |
62d6469
to
795e960
Compare
As we have done in other parts of the ecosystem bump the MSRV to Rust `v1.56.1`. Done for `secp256k1` and `secp256k1-sys`.
795e960
to
a2b78f4
Compare
Ok, done properly now git grep '1\.48'
CHANGELOG.md:22: * Bump MSRV to 1.48 [#595](https://github.com/rust-bitcoin/rust-secp256k1/pull/595)
secp256k1-sys/CHANGELOG.md:17: * Bump MSRV to 1.48 [#595](https://github.com/rust-bitcoin/rust-secp256k1/pull/595) |
Heh, this breaks the vendoring script, which looks for patterns like The offending line is line 11 of secp256k1-sys/vendor-libsecp.sh which goes
We need to tighten this To save you time I asked the chatbot to do it, which gave me
which looks a lot more legit than my old code. |
The bot is way better at writing shell that we are - glad I don't depend on writing shell for a paycheck. |
Lol, yeah. Shell has gotta be the biggest area where I'm not even close to its skill (and don't want to be :P). |
We just added `rust-version = ` to the `secp256k1-sys` manifest, doing so causes a grep statement from the vendor script to match this line - we don't want that. Tighten up the grep statement by only matching on `version` at the start of the line.
Oh, but lol, I think in this case it still won't work. I think we need to change the initial |
The bot was wrong! I used |
Hah, jinx. |
Ha, real time chatting on github. |
jinx again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2d0c783
As we have done in other parts of the ecosystem bump the MSRV to Rust
v1.56.1
.Done for
secp256k1
andsecp256k1-sys
.This was originally in #688 but there are too many things going on so here it is separately.