Accidentally closed: ~Release v0.28.0~ #621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
06-28-secp-release
branch
from
515a720
to
ff86336
Compare
tcharding
force-pushed
the
06-28-secp-release
branch
2 times, most recently
from
52e59e2
to
a28e7d1
Compare
Pinning is broken again, update the pins it CI so that the following sequence of commands would work ```bash rm Cargo.lock cargo +1.48 update -p wasm-bindgen-test --precise 0.3.34 cargo +1.48 update -p serde_test --precise 1.0.175 cargo +1.48 test --all-features ``` Note, solely out of interest, `cargo +1.48 build` does not need pinning (at the moment :)
`cargo +nightly` output of panic recently changed breaking our grep statement by adding the code line and a newline. Grep for the exact second line of the error message.
tcharding
force-pushed
the
06-28-secp-release
branch
from
a28e7d1
to
194514b
Compare
Remove the `internal_features` attribute, not sure what it was supposed to be doing but the crate works without it.
We have an unconditional panic for some combination of features, this causes clippy to give a bunch of useless warnings. Add allow attributes to quieten down clippy.
Currently the panic message refers to stuff related to development of the library, this is meaningless for users of the lib. Target panic message at secp users instead.
A while back we added two lock files that were to track dependencies of two successful test runs, one with a minimal set of dependencies and one with a recent set of dependencies (ie, recent dependency versions). We never used these lock files in CI however. In preparation for using the lock files in CI, and in order to be uniform with `rust-bitcoin`, move the lock files to the crate root and rename them to: - Cargo-minimal.lock - Cargo-recent.lock
We would like to be able to run the test script with different lock files, in preparation for doing so move the `test.sh` script to `_test.sh` and add a new `test.sh` that runs `_test.sh`. Keep the outer script as `test.sh` so that we do not change the workflow for those running the script including the github actions.
The `wasm-pack` command does not honour `cargo` flags passed to it so we cannot use `--locked` and test against pre-made lock files. Instead just run the WASM test from the test script wrapper.
Update the CI scripts to use the minimal/recent lockfiles, requires using `--locked` for various `cargo` incantations.
Use the more terse `hashes` by way of the `package` field in the manifest. Allows us to remove the ugly feature alias "bitcoin-hashes" -> "bitcoin_hashes" and removes all the bother with the underscore. Why did we not think of this 2 years ago?
Now that we have `hashes` as the crate name of `bitcoin_hashes` we can slightly clean up the import statements. This is based on the convention we have to import things directly from the crate if we depend on it and not from the crate level re-export.
WIP because the lock file changes will need redoing once hashes is released. Prepare for release of 0.28.0 by doing: - Bump the version number in the manifest - Add changelog entry - Update the commited minimal/recent lock files
tcharding
force-pushed
the
06-28-secp-release
branch
from
194514b
to
1b299ba
Compare
|
WTF I did not close that, unless I fat fingered it. |
|
Replaced by #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashesdependencyWe need a branch with this change so we can depend on it to build
bitcoinwhile updating thehashesdependency there.The last two patches are WIP because:
hashesis released