Add a verify function to XOnlyPublicKey #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2023
|
FYI this does not compile. |
Expose signature verification functionality for schnorr signatures on the `XOnlyPublicKey` type.
tcharding
force-pushed
the
06-20-verify-function
branch
from
fa094d1
to
d60b891
Compare
oof |
apoelstra
added a commit
to rust-bitcoin/rust-bitcoin
that referenced
this pull request
Jun 23, 2023
e04ac1e Add a verify function to PublicKey (Tobin C. Harding) Pull request description: Expose signature verification functionality for ECDSA signatures on the `PublicKey` type. We should have an identical function on `XOnlyPublicKey` but this will have to be done in `secp2561`: rust-bitcoin/rust-secp256k1#618 Idea from Kixunil: #1744 (comment) ACKs for top commit: apoelstra: ACK e04ac1e Kixunil: ACK e04ac1e Tree-SHA512: f26c223a1e5cc89e5c5fc12b22e621b9e8c395b8f91d7a58c6c938d45bc531e6682b178990b5a049718dbea66fff6d19d6fbcf926f142c781ad5213708ee7afa
Merge this PR already so I don't have to read that review again :) |
apoelstra
approved these changes
Jul 9, 2023
tcharding
changed the title
apoelstra
added a commit
that referenced
this pull request
Aug 11, 2023
b9cb37d Add a verify function to PublicKey (Tobin C. Harding) Pull request description: To be uniform with `XOnlyPublicKey` add a `verify` function to the `PublicKey`. Should have been done when we did #618 ACKs for top commit: apoelstra: ACK b9cb37d Tree-SHA512: e1d8127daafd18d3c9b5df6edc46a961ed49e87a44c650b92c695606002f1d4c1aee3e89822e188a65ba888abd50c5b6f247570d73fa8508d739efa8bc4df7f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose signature verification functionality for schnorr signatures on the
XOnlyPublicKeytype.Idea from Kixunil: rust-bitcoin/rust-bitcoin#1744 (comment)