-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump arduino/setup-protoc from 1 to 2 #4150
chore(deps): bump arduino/setup-protoc from 1 to 2 #4150
Conversation
@dependabot rebase |
Bumps [arduino/setup-protoc](https://github.com/arduino/setup-protoc) from 1 to 2. - [Release notes](https://github.com/arduino/setup-protoc/releases) - [Commits](arduino/setup-protoc@v1...v2) --- updated-dependencies: - dependency-name: arduino/setup-protoc dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
01f7a8c
to
6104ec2
Compare
@mihir20 this one fails with:
can you have a look what is breaking, they mention: |
@lvrach with this update of More details here: One possible resolution can be to not update arduino/setup-protoc version. Other possible solution is to use protoc version(minor version) in workflows
Concern with the later solution is what if protobuf introduces some breaking changes for go in same build version of protoc, Our github actions can fail in that case. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4150 +/- ##
==========================================
- Coverage 72.55% 72.50% -0.06%
==========================================
Files 383 383
Lines 55476 55522 +46
==========================================
+ Hits 40252 40255 +3
- Misses 12909 12937 +28
- Partials 2315 2330 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps arduino/setup-protoc from 1 to 2.
Release notes
Sourced from arduino/setup-protoc's releases.
... (truncated)
Commits
a8b67ba
bump semver to 7.5.3 (#90)1530d62
Bump semver from 7.5.1 to 7.5.2 (#87)0fbeb49
Exposepath
andversion
inoutputs
(#89)9b1ee5b
v2 release note (#82)28fd3e5
Support only the new protobuf versioning scheme (#78)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)