Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump arduino/setup-protoc from 1 to 2 #4150

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Bumps arduino/setup-protoc from 1 to 2.

Release notes

Sourced from arduino/setup-protoc's releases.

v2.0.0

Changelog

Adding support for the MINOR.PATCH tag naming

Breaking

Full Changelog: arduino/setup-protoc@v1.3.0...v2.0.0

Contributors

v1.3.0

Changelog

Enhancement

  • Support ARM64 and other platforms (#44 )

Full Changeset

arduino/setup-protoc@v1.2.0...v1.3.0

Contributors

v1.2.0

Changelog

Enhancement

Full Changeset

arduino/setup-protoc@v1.1.2...v1.2.0

v1.1.2

  • Bump lodash from 4.17.15 to 4.17.19 #8
  • Bump @​actions/core from 1.0.0 to 1.2.6 #12
  • Add pagination logic when checking for versions #1

v1.1.1

  • Define repo-token input in metadata

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 16, 2023
@mihir20
Copy link
Contributor

mihir20 commented Nov 21, 2023

@dependabot rebase

Bumps [arduino/setup-protoc](https://github.com/arduino/setup-protoc) from 1 to 2.
- [Release notes](https://github.com/arduino/setup-protoc/releases)
- [Commits](arduino/setup-protoc@v1...v2)

---
updated-dependencies:
- dependency-name: arduino/setup-protoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/arduino/setup-protoc-2 branch from 01f7a8c to 6104ec2 Compare November 21, 2023 13:36
@lvrach
Copy link
Member

lvrach commented Nov 21, 2023

@mihir20 this one fails with:

Run arduino/setup-protoc@v2
Error: Error: unable to get latest version

can you have a look what is breaking, they mention: Adding support for the MINOR.PATCH tag naming in their release notes

@mihir20
Copy link
Contributor

mihir20 commented Nov 22, 2023

@lvrach with this update of arduino/setup-protoc they are only supporting protobuf tag with minor version(protoc version) and patch. for example for protobuf version 3.24.7 in v1 of arduino/setup-protoc we need to build with version 3.x but with the new tag convention of protobuf, protobuf will upgrade the major version(3 in 3.24.7) if there is a breaking change for a programming language as a result arduino/setup-protoc are only supporting MINOR.PATCH in v2 build.

More details here:
https://protobuf.dev/support/version-support/
arduino/setup-protoc#78

One possible resolution can be to not update arduino/setup-protoc version. Other possible solution is to use protoc version(minor version) in workflows

uses: arduino/setup-protoc@v2
        with:
          version: '22.x' # in place of 3.x

Concern with the later solution is what if protobuf introduces some breaking changes for go in same build version of protoc, Our github actions can fail in that case.

@mihir20 mihir20 requested a review from lvrach November 22, 2023 11:06
@lvrach
Copy link
Member

lvrach commented Nov 22, 2023

@mihir20 I would go with 25.1 or maybe 25.x

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7b118b9) 72.55% compared to head (aa98644) 72.50%.
Report is 8 commits behind head on master.

Files Patch % Lines
processor/processor.go 90.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4150      +/-   ##
==========================================
- Coverage   72.55%   72.50%   -0.06%     
==========================================
  Files         383      383              
  Lines       55476    55522      +46     
==========================================
+ Hits        40252    40255       +3     
- Misses      12909    12937      +28     
- Partials     2315     2330      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvrach lvrach merged commit f97b69c into master Nov 27, 2023
39 checks passed
@lvrach lvrach deleted the dependabot/github_actions/arduino/setup-protoc-2 branch November 27, 2023 08:07
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants