Add support for WebSockets #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Feb 26, 2020
|
I merged my own PR... does it simplify this implementation? |
hsbt
requested changes
Feb 26, 2020
Not really .. I saw you had an open PR sitting for a while with no approvals, so I figured I would be a nice gesture to get some attention on it. Didn't realize you had approval to merge it anyway X) |
|
Nice work updating the PR. |
|
Let me know if there's anything else! This looks good to merge if the only comment was on documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds WebSocket modules (WS and WSS) to parse WebSocket URIs.
My implementation was inspired by
HTTPandHTTPSmodules/tests. If I am missing anything, please let me know.Resources I used:
https://en.wikipedia.org/wiki/WebSocket
https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Syntax
Also looked at how Python does it:
https://websockets.readthedocs.io/en/stable/_modules/websockets/uri.html
Related AWS SDK For Ruby issue:
aws/aws-sdk-ruby#2232
RFC
https://tools.ietf.org/html/rfc6455#section-3
https://tools.ietf.org/html/rfc1738 (section 3.3 for "invalid URI with user info")