[Fixes #716] deal with multiple versions in .tool-versions #717
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtannas
force-pushed
the
issue-716-multiple-tool-versions
branch
from
7bd137f to
e6e23c7
Compare
eregon
approved these changes
Mar 5, 2025
| @@ -130,7 +130,7 @@ function parseRubyEngineAndVersion(rubyVersion) { | |||
| } else if (rubyVersion === '.tool-versions') { // Read from .tool-versions | |||
| const toolVersions = fs.readFileSync('.tool-versions', 'utf8').trim() | |||
| const rubyLine = toolVersions.split(/\r?\n/).filter(e => /^ruby\s/.test(e))[0] | |||
| rubyVersion = rubyLine.match(/^ruby\s+(.+)$/)[1] | |||
| rubyVersion = rubyLine.split(/\s/)[1] | |||
There was a problem hiding this comment.
Suggested change
| rubyVersion = rubyLine.split(/\s/)[1] | |
| rubyVersion = rubyLine.match(/^ruby\s+(\S+)/)[1] |
would be another way but what you did seems fine too
I agree, that doesn't seem worth the complexity, at least not without a good use case.
Regarding treating as a matrix that's impossible, AFAIK an action cannot influence the matrix (at least in the same job). |
This was referenced Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #716 for explanation
Tested on one of my projects: https://github.com/jtannas/katachi/actions/runs/13660430691/job/38190080032?pr=19
While it might be cool for it to attempt each ruby version in order (aka. mimic ASDF parsing) or to treat multiple
.tool-versionsentries as a matrix, that's way beyond what I need and am comfortable tackling as a first PR.