Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock @actions/cache to 3.0.6, later versions break bundler caching #484

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

MSP-Greg
Copy link
Collaborator

See #483. I can't look at it until (hopefully) this weekend.

It may be a bug with @actions/cache, as I tried both 3.1.4 & 3.2.1. Not.sure.

@MSP-Greg
Copy link
Collaborator Author

Two jobs have 429 errors? That's 'Too Many Requests'? What else is going to happen today???

See:
https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
https://www.rfc-editor.org/rfc/rfc6585.html#section-4

@MSP-Greg MSP-Greg marked this pull request as draft March 17, 2023 22:20
@MSP-Greg MSP-Greg marked this pull request as ready for review March 18, 2023 01:21
@MSP-Greg
Copy link
Collaborator Author

I did some more testing, and it seems that 3.1.0 and 3.1.1 also seem to work. 3.1.2 and later do not. Also, see:

actions/toolkit#1377

@simi
Copy link

simi commented Mar 20, 2023

Thanks for addressing this @MSP-Greg. Would it be enough to restart failing checks for now, 🙏 merge and release?

@eregon
Copy link
Member

eregon commented Mar 20, 2023

My thoughts is we should avoid "blindly" updating to latest versions of dependencies without a need, things tend to break, it's not the first time. Thank you for the PR.

@MSP-Greg
Copy link
Collaborator Author

My thoughts is we should avoid "blindly" updating to latest versions of dependencies

Given that the change in @actions/cache was a minor update (not a major update), it should work. And, CI passed.

I'll see if we can add some testing to caching to verify that it works correctly. That may be difficult, given that there may be CDN delays, not sure.

JFYI, this weekend I changed the code in computeBaseKey to setup-ruby-bundler-cache-v6 (from -v5). Using @actions/cache 3.2.1, it would save the cache, but never restore it.

yarn.lock Outdated
version "4.0.0"
resolved "https://registry.yarnpkg.com/yallist/-/yallist-4.0.0.tgz#9bb92790d9c0effec63be73519e11a35019a3a72"
integrity sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has CRLF that's why the diff is so big, I'll regenerate it with LF.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry & thanks. I thought I've got Git set up so that can't happen. Maybe a new version. I'll check. But, that file is CLI generated, and my editor is always 'LF' only.

@eregon eregon merged commit ec02537 into ruby:master Mar 20, 2023
@eregon eregon linked an issue Mar 20, 2023 that may be closed by this pull request
2 tasks
@eregon
Copy link
Member

eregon commented Mar 20, 2023

I'll see if we can add some testing to caching to verify that it works correctly. That may be difficult, given that there may be CDN delays, not sure.

Maybe we can do that by using ruby/setup-ruby twice in in the same workflow job, and having some debug env var or so to fail if the cache isn't restored in the 2nd usage.

@MSP-Greg
Copy link
Collaborator Author

MSP-Greg commented Mar 20, 2023

Maybe we can do that by using ruby/setup-ruby twice in in the same workflow job, and having some debug env var or so to fail if the cache isn't restored in the 2nd usage.

Yes, I thought something similar. I'm back to testing this because I'm just a little frustrated by it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Restoring bundler cache is not working in v1.144.1
3 participants