Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Repair format of What's Here sections in object.c #5722

Merged
merged 2 commits into from
Mar 29, 2022
Merged

[DOC] Repair format of What's Here sections in object.c #5722

merged 2 commits into from
Mar 29, 2022

Conversation

BurdetteLamar
Copy link
Member

No description provided.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Mar 26, 2022
Comment on lines +4198 to +4199
* - {!}[#method-i-21]: Returns the boolean negation of +self+: +true+ or +false+.
* - {!=}[#method-i-21-3D]: Returns whether +self+ and the given object are _not_ equal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - {!}[#method-i-21]: Returns the boolean negation of +self+: +true+ or +false+.
* - {!=}[#method-i-21-3D]: Returns whether +self+ and the given object are _not_ equal.
* - #!: Returns the boolean negation of +self+: +true+ or +false+.
* - #!=: Returns whether +self+ and the given object are _not_ equal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested revisions above do not become links on my system:

  • $ ruby --version
    ruby 3.1.0p0 (2021-12-25 revision fb4df44) [x64-mingw-ucrt]
  • $ rdoc --version
    6.4.0

Is this fixed in later versions?

There are many more like this in the What's Here sections. When they are no longer needed, I'll be happy to do a sweep through to clean them up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed at ruby/rdoc#865 and has been merged to the ruby master, but rdoc is not released yet.

Comment on lines +4243 to +4246
* - {!~}[#method-i-21~]: Returns +true+ if +self+ does not match the given object,
* otherwise +false+.
* - {<=>}[#method-i-3C-3D-3E]: Returns 0 if +self+ and the given object +object+ are the same
* object, or if <tt>self == object</tt>; otherwise returns +nil+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - {!~}[#method-i-21~]: Returns +true+ if +self+ does not match the given object,
* otherwise +false+.
* - {<=>}[#method-i-3C-3D-3E]: Returns 0 if +self+ and the given object +object+ are the same
* object, or if <tt>self == object</tt>; otherwise returns +nil+.
* - #!~: Returns +true+ if +self+ does not match the given object,
* otherwise +false+.
* - #<=>: Returns 0 if +self+ and the given object +object+ are the same
* object, or if <tt>self == object</tt>; otherwise returns +nil+.

* - #spawn:: Executes the given command and returns its pid without waiting
* for completion.
* - #system:: Executes the given command in a subshell.
* - {`command`}[#method-i-60]: Returns the standard output of running +command+ in a subshell.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the canonical notation is #` here, and command` is extraneous.
Do you think #`command` should be parsed as single method reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm agnostic on this one. In the What's Here section, #</tt> in source would become a link with just the one character <tt>, a tiny target even if correct. How would you like this to be?

Also, #` did not link on my machine (versions same as above).

@BurdetteLamar BurdetteLamar requested a review from nobu March 27, 2022 20:00
@BurdetteLamar
Copy link
Member Author

@nobu, can we leave these links as-is for now, and deal with all such (in all classes) all at once, and later? If so, I'll still need an approval from you or @jeremyevans.

@nobu
Copy link
Member

nobu commented Mar 29, 2022

Do you mean to change just the method list styles?
I'm ok for it.

@BurdetteLamar
Copy link
Member Author

Do you mean to change just the method list styles? I'm ok for it.

I mean to merge now, then fix after the fix is released. Ok?

@BurdetteLamar BurdetteLamar merged commit c8e1ae4 into ruby:master Mar 29, 2022
@BurdetteLamar
Copy link
Member Author

When the fix at 385 is released, I will sweep through all classes that should make use of it.

@BurdetteLamar
Copy link
Member Author

Sorry, @nobu, I did not understand you about merging this; now I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
2 participants