Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safe readline #669

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Thread safe readline #669

merged 1 commit into from
Apr 4, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Mar 26, 2024

Block until other Reline.readline or Reline.readmultiline finish

Diff: files?w=1

Combination with #668, I think #667 will be fixed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Block until other Reline.readline or Reline.readmultiline finish
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@ima1zumi ima1zumi merged commit ebab287 into ruby:master Apr 4, 2024
40 checks passed
@tompng tompng deleted the threadsafe branch April 4, 2024 16:59
matzbot pushed a commit to ruby/ruby that referenced this pull request Apr 5, 2024
(ruby/reline#669)

Block until other Reline.readline or Reline.readmultiline finish

ruby/reline@ebab2875f1
@ima1zumi ima1zumi added the bug Something isn't working label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants