-
Notifications
You must be signed in to change notification settings - Fork 439
Move doc/markup_reference.rb to doc/rdoc #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what problem this is supposed to solve. It just includes the file doc/markup_reference.rb
in the built .gem
file that is built, but markup_reference.rb
is just documentation, so I don't see why it's included in the built gem.
See https://ruby.slack.com/archives/C02A3SL0S/p1658264615750489. I think this PR solves the problem. |
I don't see how this PR solves the problem. docs.ruby-lang.org is built from the ruby/ruby repository. I don't think this will sync the |
Somehow, doc/ files from ruby/csv get into ruby/ruby, but doc/ files from ruby/rdoc don't. If this is not the way, do you know how to make that happen? |
From what I can tell, it looks manually sync'd, not automatically. Looks like that tool to do the sync is in |
So I would add to the clause |
It would be a good idea to move all the files in the cp_r("#{upstream}/doc/rdoc", "doc") |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the PR title to match the changes? Otherwise it looks good.
No description provided.