Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support crossref of methods with multiple arguments #871

Merged
merged 1 commit into from Mar 9, 2022
Merged

Support crossref of methods with multiple arguments #871

merged 1 commit into from Mar 9, 2022

Conversation

peterzhu2118
Copy link
Member

For example, consider the following markup:

C1#m(a, b)

Before this patch, it generated this HTML:

<p><a href=\"C1.html#method-i-m\"><code>C1#m</code></a>(a, b)</p>

Which places the method arguments outside of the link.

Now it generates this HTML:

<a href=\"C1.html#method-i-m\"><code>C1#m(a, b)</code></a>

@peterzhu2118
Support crossref of methods with multiple arguments
05a2b22 
For example, consider the following markup:

  C1#m(a, b)

Before this patch, it generated this HTML:

  <p><a href=\"C1.html#method-i-m\"><code>C1#m</code></a>(a, b)</p>

Which places the method arguments outside of the link.

Now it generates this HTML:

  <a href=\"C1.html#method-i-m\"><code>C1#m(a, b)</code></a>
@peterzhu2118 peterzhu2118 mentioned this pull request Mar 8, 2022
Merged
@peterzhu2118 peterzhu2118 merged commit 98b4e65 into ruby:master Mar 9, 2022
@peterzhu2118 peterzhu2118 deleted the crossref-method-args branch March 9, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@peterzhu2118