Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call update_extends in ClassModule#complete #1317

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Mar 16, 2025

For unknown reasons, this method was not being called in #complete, which led to duplicated extends in some cases.

Verified

This commit was signed with the committer’s verified signature.
atollena Antoine Tollenaere
For unknown reasons, this method was not being called in `#complete`,
which led to duplicated extends in some cases.
Copy link

Deploying rdoc with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef69459
Status: ✅  Deploy successful!
Preview URL: https://9ed30f6d.rdoc-6cd.pages.dev
Branch Preview URL: https://fix-duplicated-extends.rdoc-6cd.pages.dev

View logs

Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompng tompng merged commit 0e5a763 into master Mar 16, 2025
60 checks passed
@tompng tompng deleted the fix-duplicated-extends branch March 16, 2025 13:04
@st0012 st0012 changed the title Call update_extends in ClassModule#complete Call update_extends in ClassModule#complete Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants