Skip to content

Relax paragraph pattern #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2025
Merged

Relax paragraph pattern #1299

merged 5 commits into from
Mar 8, 2025

Conversation

nobu
Copy link
Member

@nobu nobu commented Feb 28, 2025

Not all paragraphs in documentations start with a capital letter, as usual English text.

Fix #1298

nobu added 3 commits March 7, 2025 16:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fix ruby#1298
Not all paragraphs in documentations start with a capital letter, as
usual English text.
@nobu nobu force-pushed the paragraph-excerpt branch from 5328d61 to 3351d5b Compare March 7, 2025 07:40
@nobu nobu force-pushed the paragraph-excerpt branch 2 times, most recently from 127b72b to 5027f85 Compare March 7, 2025 13:20
@nobu nobu force-pushed the paragraph-excerpt branch 2 times, most recently from 0ed8f01 to eb3a5ba Compare March 7, 2025 13:40
@vinistock
Copy link
Collaborator

The fix looks good to me, but I don't know why only JRuby is raising a conversion error.

@nobu
Copy link
Member Author

nobu commented Mar 7, 2025

Me too, and reported to JRuby (jruby/jruby#8682)

Copy link
Collaborator

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Nobu

@nobu nobu merged commit 0a541fb into ruby:master Mar 8, 2025
60 checks passed
@nobu nobu deleted the paragraph-excerpt branch March 8, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Not All paragraphs start with a capital letter, as usual English text.
2 participants