fix: Return empty string when token_stream is nil
#1056
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in ruby#1055 might be a breaking change. So, just simply wrap `token_stream` with `Array` Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
toshimaru
force-pushed
the
follow-up-1055
branch
from
8050211
to
604dc16
Compare
nobu
reviewed
Nov 27, 2023
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
toshimaru
changed the title
token_stream.to_s when token_stream is niltoken_stream is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #1055 could be a breaking change (see. #1055 (comment)).
As a simple workaround, return empty string when
token_streamisnil.Additionally, a test for
test_token_streamhas been added.