Make the test suite compatible with --enable-frozen-string-literal
#1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
commented
Mar 15, 2024
| @@ -1,3 +1,4 @@ | |||
| # frozen_string_literal: false | |||
There was a problem hiding this comment.
Lots of tested methods mutate the string, so it's simpler to globally use mutable strings in this file.
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `rbs` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
force-pushed
the
enable-frozen-string-literal
branch
from
42c5f9e
to
9fb3f79
Compare
It just got released 🎉 . So I update the PR to no longer use a git gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/20205
Ref: voxpupuli/json-schema#508
Since
rbsis tested as part of ruby-core CI, it needs to be compatible with the--enable-frozen-string-literaloption.NB: Thejson-schemafix was merged, but not sure when it will be released. I don't know if using a git gem is a blocker?