Avoid shelling *nix commands #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces platform expectations; e.g., Windows building without specifying MSYS
ParadoxV5
commented
Apr 14, 2024
| @@ -6,7 +6,7 @@ Q1 = $(V:1=) | |||
| Q = $(Q1:0=@) | |||
| ECHO1 = $(V:1=@ :) | |||
| ECHO = $(ECHO1:0=@ echo) | |||
| FUZZ_OUTPUT_DIR = $(shell pwd)/fuzz/output | |||
| FUZZ_OUTPUT_DIR = $(CURDIR)/fuzz/output | |||
There was a problem hiding this comment.
CURDIR is technically different from shell pwd in that the latter isn’t stuck constant if the Makefile somehow cds halfway in the script.
That said, do we really want the build to base on the working directory rather than fixed at the repo root?
ParadoxV5
commented
Apr 14, 2024
Comment on lines
+18
to
+19
| HEADERS := $(wildcard include/*.h include/*/*.h include/*/*/*.h') | ||
| SOURCES := $(wildcard src/*.c src/*/*.c) |
There was a problem hiding this comment.
Makefile doesn’t support recursive wildcard, so shelling out was accustomed.
The alternative is to write a custom function.
I’m fine with abandoning this change if it’s not worth to not shell-out.
For reference, mkmf-generated Makefiles does not expand recursively; that is, mkmf does not support source code subfolders.
kddnewton
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extconf.rb: SendRbConfigpreferences to#makevia env vars #2705Some of the commands used in the
Makefileare not covered byRbConfig.Coïncidentally, they’re all
$(shell …)calls.This PR replaces them with alternatives that do not assume the availability of *nix commands.