Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile: Print the message with Rake.rake_output_message. #632

Merged
merged 1 commit into from Jun 1, 2023

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Jun 1, 2023

The puts method outputs the message to the $stdout, while the sh method outputs the message of the executed command to the $stderr by the Rake.rake_output_message.
https://github.com/ruby/rake/blob/v13.0.6/lib/rake/file_utils.rb#L51

This caused the message Compiler: ... not printed before the actual compiling task like the CI result below.
https://github.com/ruby/openssl/actions/runs/5142797693/jobs/9256988158#step:6:141.

The `puts` method outputs the message to the `$stdout`, while the `sh` method
outputs the message of the executed command to the `$stderr` by the
`Rake.rake_output_message`.
https://github.com/ruby/rake/blob/v13.0.6/lib/rake/file_utils.rb#L51

This caused the message `Compiler: ...` not printed before the actual compiling
task like the CI result below.
<https://github.com/ruby/openssl/actions/runs/5142797693/jobs/9256988158#step:6:141>.
@junaruga
Copy link
Member Author

junaruga commented Jun 1, 2023

I confirmed that the Compiler: ... message is printed in the right sort before printing the messages by the compiling task in this PR's CI.

@junaruga junaruga merged commit 5f505c5 into ruby:master Jun 1, 2023
42 checks passed
@junaruga junaruga deleted the wip/rake-debug-compiler-message branch June 1, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant