✨ Add greeting code data to responses #94
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
response-handlers
branch
from
cfcbcd5 to
89ae479
Compare
nevans
force-pushed
the
record-greeting-response-code-data
branch
from
1b5e0cb to
10db63c
Compare
nevans
force-pushed
the
response-handlers
branch
2 times, most recently
from
223055e to
800edb8
Compare
This simplifies caching of the server capabilities, as many servers will send their capabilities inside the greeting. Needed for #31.
nevans
force-pushed
the
record-greeting-response-code-data
branch
from
10db63c to
4424213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies caching of the server capabilities, as many servers will send their capabilities inside the greeting. It's needed for #31.
The PR is based on #93 only because my test for it is based on that branch. But that PR is a bigger change than this one, so I can rebase this and give it its own test, if necessary.