Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input line mutation out of Context#evaluate #615

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jun 27, 2023

This makes sure Context#evaluate really just evaluates the input. It will also make #575's implementation cleaner.

This makes sure `Context#evaluate` really just evaluates the input.
It will also make #575's implementation cleaner.
@st0012 st0012 self-assigned this Jun 27, 2023
@st0012 st0012 requested a review from a team June 27, 2023 11:14
Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompng tompng merged commit 27b0559 into master Jun 27, 2023
47 checks passed
@tompng tompng deleted the cleanup-context-evaluate branch June 27, 2023 19:51
matzbot pushed a commit to ruby/ruby that referenced this pull request Jun 27, 2023
(ruby/irb#615)

This makes sure `Context#evaluate` really just evaluates the input.
It will also make #575's implementation cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants