Enable trap function accept Integer(Non-String) #976
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
reviewed
Jul 28, 2023
| @@ -2524,7 +2524,7 @@ def daemon(*args) | |||
|
|
|||
| module TrapInterceptor | |||
| def trap sig, *command, &command_proc | |||
| case sig&.to_sym | |||
| case sig&.to_s&.to_sym | |||
There was a problem hiding this comment.
This won't handle integers correctly, because they won't fall into :INT and :SIGINT below. This would do it:
case sig&.to_s&.to_sym
when :INT, :SIGINT, :"2"
if defined?(SESSION) && SESSION.active? && SESSION.intercept_trap_sigint?
return SESSION.save_int_trap(command.empty? ? command_proc : command.first)
end
end
There was a problem hiding this comment.
Sorry I missed your comment. Could you make an issue or PR for it with examples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the following code, Signal.#trap method is overridden.
https://github.com/ruby/debug/blob/v1.7.2/lib/debug/session.rb#L2520
Although the original trap code can accept Integer, the above can't.
That's why I enabled trap function accept Integer(Non-String).
Relates to #975