Fix include_missing for aliased parameters #1752
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasoberschweiber
force-pushed
the
alias-include-missing-fix
branch
from
24ef771 to
28b291b
Compare
dblock
reviewed
Mar 15, 2018
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| * [#1737](https://github.com/ruby-grape/grape/pull/1737): Fix translating error when passing symbols as params in custom validations - [@mlzhuyi](https://github.com/mlzhuyi). | |||
| * [#1749](https://github.com/ruby-grape/grape/pull/1749): Allow rescue from non-`StandardError` exceptions - [@dm1try](https://github.com/dm1try). | |||
| * [#1750](https://github.com/ruby-grape/grape/pull/1750): Fix a circular dependency warning due to router being loaded by API - [@salasrod](https://github.com/salasrod). | |||
| * [#1752](https://github.com/ruby-grape/grape/pull/1752): Fix `include_missing` behavior for aliased parameters - [@jonasoberschweiber](https://github.com/jonasoberschweiber) | |||
There was a problem hiding this comment.
This is missing a period so it complains.
There was a problem hiding this comment.
Fixed, thanks.
jonasoberschweiber
force-pushed
the
alias-include-missing-fix
branch
from
28b291b to
792417c
Compare
|
Good work @jonasoberschweiber, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include_missingcurrently includes aliased parameters even if they're not specified. The existing test forinclude_missingwas also broken, it passed regardless of the value ofinclude_missing.