Optional nested array validation #1724
Merged
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resent Added specs
Added rubocop_todo
Refactor specs
We do not validate if all empty We skip validation if parents is optional
dblock
reviewed
Dec 28, 2017
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| * [#1688](https://github.com/ruby-grape/grape/pull/1688): Removes yard docs - [@ramkumar-kr](https://github.com/ramkumar-kr). | |||
| * [#1702](https://github.com/ruby-grape/grape/pull/1702): Added danger-toc, verify correct TOC in README - [@dblock](https://github.com/dblock). | |||
| * [#1711](https://github.com/ruby-grape/grape/pull/1711): Automatically coerce arrays and sets of types that implement a `parse` method - [@dslh](https://github.com/dslh). | |||
| * [#1724](https://github.com/ruby-grape/grape/pull/1724): Optional nested array validation - [@ericproulx](https://github.com/ericproulx). | |||
dblock
reviewed
Dec 28, 2017
| { foo: 'three' } | ||
| ] } | ||
| get '/nested_optional_array', root: params | ||
| expect(last_response.status).to eq(400) |
There was a problem hiding this comment.
Test that the actual response contains the correct value being wrong. Maybe break this one up more, too.
There was a problem hiding this comment.
I don't understand
There was a problem hiding this comment.
In this case the status can be 400 for all kinds of reasons. Check last_response.body that it says something about the parameter being incorrect.
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1636 Merry 🎄