Fix undefined method Logger when processing watched file notifications #13822
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for handling watched file notifications was crashing every time because it was trying to invoke
Logger()
, which is a module not a method. The actual method isLogger.log
.I added a test to verify that the runtime adapter is properly reloaded whenever the config file is updated.
Note: I did not use an RSpec's subject block for this test because we need to verify things inside the
with_server
block, while add-ons are still loaded and activated (the method unloads them at the end). The watched files notification doesn't return a response (because it's an LSP notification and not a request) and so this is the only way to verify what's happening.Please let me know if you want to include this in the changelog.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.