Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/AssignmentInConditional if assigning inside a method call #12828

Merged

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Apr 10, 2024

This reverts d0828e5 and adds a testcase.

The correction is return unless %i[asc desc].include?((order = params[:order])) which just doesn't look right.

cc @jonas054


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…inside a method call.

This reverts d0828e5 and adds a testcase
@Earlopain Earlopain force-pushed the false-positive-for-assignment-in-conditional branch from 908971b to 5ab7540 Compare April 10, 2024 10:04
@bbatsov bbatsov merged commit b562b74 into rubocop:master Apr 10, 2024
33 checks passed
@Earlopain Earlopain deleted the false-positive-for-assignment-in-conditional branch April 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants