Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12807] Fix false positives for Naming/BlockForwarding #12808

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 22, 2024

Fixes #12807.

This PR fixes false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_false_positives_for_naming_block_forwarding branch 2 times, most recently from 586f550 to e1ea4db Compare March 22, 2024 20:26
Fixes rubocop#12807.

This PR fixes false positives for `Naming/BlockForwarding`
when using explicit block forwarding in block method and others.
@koic koic force-pushed the fix_false_positives_for_naming_block_forwarding branch from e1ea4db to 2d4afd1 Compare March 22, 2024 20:36
@koic koic merged commit f1b8abc into rubocop:master Mar 23, 2024
33 checks passed
@koic koic deleted the fix_false_positives_for_naming_block_forwarding branch March 23, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming/BlockForwarding with -a creates syntax error
1 participant