Return global offenses for Naming/FileName
and Naming/InclusiveLanguage
#12802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking against filenames, a global offense should be added. The current behaviour causes problems in things like LSPs that inspect the offense for location information since some operations on these offenses will raise a
IndexError
.I've tweaked the specs for
InclusiveLanguage
since they just passed without any changes. With the annotation expectations, it actually checks the offense location (or lack thereof).As a note,
Style/Copyright
can add a offense in exactly the same way. However, since it supports autocorrect just switching toadd_global_offense
is not possible.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.