Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/Alias when calling alias_method with fewer than 2 arguments. #12782

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Earlopain
Copy link
Contributor

This happens in every context. Classes, Modules, etc. I don't believe it necessary to add one for each. I've also added tests for the other EnforcedStyle but it doesn't raise currently.

I've added no tests for alias calls with fewer arguments call since that is just a syntax error.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Earlopain Earlopain force-pushed the fix-error-for-style-alias-spec branch from 1a561d3 to 00c0a84 Compare March 12, 2024 15:40
@koic koic merged commit afddf65 into rubocop:master Mar 12, 2024
33 checks passed
@Earlopain Earlopain deleted the fix-error-for-style-alias-spec branch March 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants