Fix an infinite loop for Style/MultilineMethodSignature when line break after def
#12763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reak after def This commit removes this exit condition from `expect_correction`. It is now only considered done when there are no correctors anymore. This has hidden the infinite loop this commit fixes.
|
Looks good to me. Thanks! |
Earlopain
deleted the
fix-infitite-loop-for-style-multiline-method-signature
branch
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 11, 2024
…haviour The change for this was made in rubocop#12763 and rubocop#12774
8 tasks
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 15, 2024
…haviour The change for this was made in rubocop#12763 and rubocop#12774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes a part of #8090, specifically at 448eb96. There don't seem to be any consequences of doing so except for uncovering this bug.
A test case for this issue has already been added in #11768 but after the result has been reached there are still correctors that result in an infinite loop. In practice some other cop comes in first and makes this situation unlikely to actually encounter, unless it is disabled of course.
While I was working on #12753 I got into a similar situation, where my assertions where passing but actually running it on the codebase resulted in an infinite loop.
This PR fixes the ininite loop and makes these situations impossible by only considering a correction done if there are no correctors left.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.