Skip LineLength phase on --auto-gen-only-exclude
#12730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
force-pushed
the
skip-line-length-phase-on-only-excludes
branch
from
d141a18
to
e915229
Compare
|
The proposed change looks reasonable to me. @jonas054 please take a look as well. |
jonas054
reviewed
Mar 6, 2024
jonas054
requested changes
Mar 6, 2024
sambostock
force-pushed
the
skip-line-length-phase-on-only-excludes
branch
from
e915229
to
2edc7ab
Compare
Phase 1 of config auto-generation runs the `Layout/LineLength` cop on all files to discover the `Max` line length, so it can be used by cops which depend on it. The `--auto-gen-only-exclude` config skips generating any `Max` configs, meaning phase 1 is redundant, as we won't generate the `Max` for use by phase 2. Therefore, we can skip phase 1 entirely.
sambostock
force-pushed
the
skip-line-length-phase-on-only-excludes
branch
from
2edc7ab
to
15fb5c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 1 of config auto-generation runs the
Layout/LineLengthcop on all files to discover theMaxline length, so it can be used by cops which depend on it.The
--auto-gen-only-excludeconfig skips generating anyMaxconfigs, meaning phase 1 is redundant, as we won't generate theMaxfor use by phase 2.Therefore, we can skip phase 1 entirely. Even though we're only running
Layout/LineLength, parsing the entire codebase twice can get quite time consuming on large repositories.Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.