Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12632] Fix an infinite loop error for Style/ArgumentsForwarding #12633

Conversation

koic
Copy link
Member

@koic koic commented Jan 18, 2024

Fixes #12632.

This PR fixes an infinite loop error when EnforcedStyle: explicit of Naming/BlockForwarding with Style/ArgumentsForwarding.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…rwarding`

Fixes rubocop#12632.

This PR fixes an infinite loop error when `EnforcedStyle: explicit` of
`Naming/BlockForwarding` with `Style/ArgumentsForwarding`.
@koic koic force-pushed the fix_infinite_loop_error_for_style_argument_forwarding branch from c6ae684 to 124ee9f Compare January 18, 2024 09:47
@bbatsov bbatsov merged commit a6cf5a7 into rubocop:master Jan 22, 2024
32 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 22, 2024

Thanks!

@koic koic deleted the fix_infinite_loop_error_for_style_argument_forwarding branch January 23, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants