Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/RedundantParentheses #12607

Conversation

koic
Copy link
Member

@koic koic commented Jan 10, 2024

This PR fixes a false positive for Style/RedundantParentheses when regexp literal attempts to match against a parenthesized condition.

The presence or absence of parentheses here changes the meaning of the syntax, so the parentheses are not redundant:

$ ruby-parse -e '/regexp/ =~ (foo || bar)'
(match-with-lvasgn
  (regexp
    (str "regexp")
    (regopt))
  (begin
    (or
      (send nil :foo)
      (send nil :bar))))

$ ruby-parse -e '/regexp/ =~ foo || bar'
(or
  (match-with-lvasgn
    (regexp
      (str "regexp")
      (regopt))
    (send nil :foo))
  (send nil :bar))

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes a false positive for `Style/RedundantParentheses`
when regexp literal attempts to match against a parenthesized condition.

The presence or absence of parentheses here changes the meaning of the syntax,
so the parentheses are not redundant:

```console
$ ruby-parse -e '/regexp/ =~ (foo || bar)'
(match-with-lvasgn
  (regexp
    (str "regexp")
    (regopt))
  (begin
    (or
      (send nil :foo)
      (send nil :bar))))

$ ruby-parse -e '/regexp/ =~ foo || bar'
(or
  (match-with-lvasgn
    (regexp
      (str "regexp")
      (regopt))
    (send nil :foo))
  (send nil :bar))
```
@koic koic force-pushed the fix_false_positive_for_style_redundant_parentheses branch from 476a58b to ac5539c Compare January 10, 2024 09:28
@bbatsov bbatsov merged commit 61f9245 into rubocop:master Jan 11, 2024
32 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 11, 2024

The change is good, but I think it'd be also good to expand a bit the description of the cop and its examples, as both are too basic right now.

@koic koic deleted the fix_false_positive_for_style_redundant_parentheses branch January 11, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants