[Fix #12233] Make Style/SlicingWithRange aware of beginless range
#12594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…range Fixes rubocop#12233. This PR makes `Style/SlicingWithRange` aware of redundant and beginless range. Ruby 2.7 introduced beginless ranges. But, unlike the somewhat obscure `-1` in `ary[1..-1]`, the `0` in `ary[0..42]` is clear as a starting point. In fact, changing it to `ary[..42]` could potentially make it less readable. Therefore, `ary[0..42]` should respect the original programmer's intent. On the other hand, `ary[nil..42]` could be replaced with `ary[..42]`. Similarly, `ary[1..nil]` could be replaced with `ary[1..]`. Moreover, `[0..-1]` in `ary[0..-1]` is redundant and simply synonymous with `ary`. This PR has also made adjustments to detect this case. While this is a byproduct of supporting beginless and endless ranges, I think including this change in `Style/SlicingWithRange` cop may be suitable and not feel out of place.
|
I'm fine with the proposed changes, but I'd suggest to also add an entry to the style guide about this. |
koic
deleted the
make_style_slicing_with_range_aware_of_beginless_range
branch
koic
added a commit
to koic/ruby-style-guide
that referenced
this pull request
Jan 12, 2024
Follow up rubocop/rubocop#12594 (comment). This PR adds "Slicing with Ranges" rule.
koic
added a commit
to koic/ruby-style-guide
that referenced
this pull request
Jan 12, 2024
Follow up rubocop/rubocop#12594 (comment). This PR adds "Slicing with Ranges" rule.
bbatsov
pushed a commit
to rubocop/ruby-style-guide
that referenced
this pull request
Jan 13, 2024
Follow up rubocop/rubocop#12594 (comment). This PR adds "Slicing with Ranges" rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12233.
This PR makes
Style/SlicingWithRangeaware of redundant and beginless range.Ruby 2.7 introduced beginless ranges. But, unlike the somewhat obscure
-1inary[1..-1], the0inary[0..42]is clear as a starting point. In fact, changing it toary[..42]could potentially make it less readable. Therefore,ary[0..42]should respect the original programmer's intent. On the other hand,ary[nil..42]could be replaced withary[..42]. Similarly,ary[1..nil]could be replaced withary[1..].Moreover,
[0..-1]inary[0..-1]is redundant and simply synonymous withary. This PR has also made adjustments to detect this case. While this is a byproduct of supporting beginless and endless ranges, I think including this change inStyle/SlicingWithRangecop may be suitable and not feel out of place.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.