[Fix #12444] Fix false positive for Style/HashEachMethods
#12508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_style_hash_each_methods
branch
from
0927724
to
aa1d624
Compare
ydakuka
reviewed
Dec 4, 2023
|
|
||
| it "does not register an offense when `['array', 'literal'].keys.each`" do | ||
| expect_no_offenses(<<~RUBY) | ||
| ['array', 'literal'].keys.each { |k| p k } |
There was a problem hiding this comment.
This code is broken.
2.7.6 :002 > ['array', 'literal'].keys.each { |k| p k }
Traceback (most recent call last):
4: from /home/ydakuka/.rvm/rubies/ruby-2.7.6/bin/irb:23:in `<main>'
3: from /home/ydakuka/.rvm/rubies/ruby-2.7.6/bin/irb:23:in `load'
2: from /home/ydakuka/.rvm/rubies/ruby-2.7.6/lib/ruby/gems/2.7.0/gems/irb-1.2.6/exe/irb:11:in `<top (required)>'
1: from (irb):1
NoMethodError (undefined method `keys' for ["array", "literal"]:Array)There was a problem hiding this comment.
The issue describes another case: there is a #each with two args and second one is not used.
[[1, 2, 3], [4, 5, 6]].each { |a, _| puts(a) }And if I run rubocop, I'll get the following:
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/models/test.rb
Inspecting 1 file
C
Offenses:
app/models/test.rb:30:5: C: [Correctable] Style/HashEachMethods: Use each_key instead of each and remove the unused _ block argument.
[[1, 2, 3], [4, 5, 6]].each { |a, _| puts(a) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1 file inspected, 1 offense detected, 1 offense autocorrectable
koic
force-pushed
the
fix_a_false_positive_for_style_hash_each_methods
branch
3 times, most recently
from
f5ad65b
to
95d0e46
Compare
bbatsov
reviewed
Dec 9, 2023
| @@ -88,6 +90,12 @@ def on_block_pass(node) | |||
|
|
|||
| private | |||
|
|
|||
| def handlable?(node) | |||
There was a problem hiding this comment.
Did you meant to write "handleable"?
There was a problem hiding this comment.
Oops, this is a typo. I've fixed it.
Fixes rubocop#12444. This PR fixes false positive for `Style/HashEachMethods` when receiver literal is not a hash literal.
koic
force-pushed
the
fix_a_false_positive_for_style_hash_each_methods
branch
from
95d0e46
to
23a9f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12444.
This PR fixes false positive for
Style/HashEachMethodswhen receiver literal is not a hash literal.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.