Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12424] Make Style/HashEachMethods aware of safe navigation operator #12426

Conversation

koic
Copy link
Member

@koic koic commented Dec 1, 2023

Fixes #12424.

This PR makes Style/HashEachMethods aware of safe navigation operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…tion operator

Fixes rubocop#12424.

This PR makes `Style/HashEachMethods` aware of safe navigation operator.
@koic koic force-pushed the make_style_hash_each_methods_aware_of_safe_navigation_operator branch from 784afb9 to 7250a78 Compare December 1, 2023 04:26
@bbatsov bbatsov merged commit c8d2d77 into rubocop:master Dec 1, 2023
28 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 1, 2023

Looks good to me. Thanks!

@koic koic deleted the make_style_hash_each_methods_aware_of_safe_navigation_operator branch December 1, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Style/HashEachMethods aware of safe navigation operator
2 participants