Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults
#12418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Nov 26, 2023
| # foo&.to_h || {} | ||
| # | ||
| # # good | ||
| # foo.to_h |
There was a problem hiding this comment.
It would be useful to document other literals as well.
koic
reviewed
Nov 26, 2023
| range = range_between(node.lhs.loc.dot.begin_pos, node.source_range.end_pos) | ||
|
|
||
| add_offense(range) do |corrector| | ||
| corrector.replace(node, "#{receiver.source}.#{method_name}") |
There was a problem hiding this comment.
Suggested change
| corrector.replace(node, "#{receiver.source}.#{method_name}") | |
| corrector.replace(range, ".#{method_name}") |
koic
reviewed
Nov 26, 2023
| it 'registers an offense and corrects when `.&` is used in `.to_h` coversion with default' do | ||
| expect_offense(<<~RUBY) | ||
| foo&.to_h || {} | ||
| ^^^^^^^^^^^^ Redundant safe navigation detected. |
There was a problem hiding this comment.
In such cases, adjusting the message a bit would likely prevent user confusion. e.g.:
Suggested change
| ^^^^^^^^^^^^ Redundant safe navigation detected. | |
| ^^^^^^^^^^^^ Redundant safe navigation with default literal value detected. |
fatkodima
force-pushed
the
redundant_safe_navigation-conversions-with-defaults
branch
from
397ce9b
to
2429636
Compare
|
Updated. |
|
The example is missing: # bad
hsh&.to_h { |k, v| [k, v] } || {}
# good
hsh.to_h { |k, v| [k, v] }
This should fix the following offenses: https://github.com/gitlabhq/gitlabhq/blob/master/lib/security/ci_configuration/sast_build_action.rb#L24 |
fatkodima
force-pushed
the
redundant_safe_navigation-conversions-with-defaults
branch
from
2429636
to
fe5ed60
Compare
|
Thanks. Let's proceed with this first. |
fatkodima
deleted the
redundant_safe_navigation-conversions-with-defaults
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12412.
With these changes I found a few offenses in the gitlab's codebase.