Add new Style/ArrayFirstLast cop
#12416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the methods are specific only to arrays, I guess we can name the cop "ArrayFirstLast" or something more generic like "ArrayElementAccess". Might be good to make this configurable for whoever prefers indices as well, although I don't feel strongly about this.
Makes sense. |
fatkodima
force-pushed
the
style-first_last_cop
branch
from
a318917
to
ae7835a
Compare
fatkodima
changed the title
Style/FirstLast copStyle/ArrayFirstLast cop
|
Changed the name. |
|
Documenting the reason for being disabled by default will help users understand. |
fatkodima
force-pushed
the
style-first_last_cop
branch
from
ae7835a
to
b09b40d
Compare
|
Added a line regarding why it is disabled. |
bbatsov
reviewed
Nov 27, 2023
| # The cop is disabled by default due to safety concerns. | ||
| # | ||
| # @safety | ||
| # Autocorrection is unsafe because `[0]` or `[-1]` can be called on a Hash, |
There was a problem hiding this comment.
Not just the autocorrection is unsafe - the cop is fundamentally unsafe. :-)
There was a problem hiding this comment.
Sure, copy paste error 🤦 😅
fatkodima
force-pushed
the
style-first_last_cop
branch
from
b09b40d
to
4525396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12406.
I already implemented this cop (so that's why still decided to open a PR) when realised that
.first/.lastis only suited for arrays. While[0]and[-1]can be also used with strings or hashes. So this can probably generate many false positives. I made it disabled by default.