Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Style/MapToHash aware of safe navigation operator #12408

Conversation

koic
Copy link
Member

@koic koic commented Nov 24, 2023

Follow up #12407 (comment).

This PR makes Style/MapToHash aware of safe navigation operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up rubocop#12407 (comment).

This PR makes `Style/MapToHash` aware of safe navigation operator.
@koic koic force-pushed the make_style_map_to_hash_aware_of_safe_navigation_operator branch from cac1a4f to f4e4668 Compare November 24, 2023 10:01
@ydakuka
Copy link

ydakuka commented Nov 24, 2023

Another false-negative for the Style/MapToHash. Sorry for the delay between examples :)

hsh = [['a', '1'], ['b', '2']]
# hsh = nil

# bad
hsh&.map { |k, v| [k, v] }.to_h

# good
hsh.to_h { |k, v| [k, v] }

@ydakuka
Copy link

ydakuka commented Nov 24, 2023

And

hsh = [['a', '1'], ['b', '2']]
# hsh = nil

# bad
hsh&.to_h { |k, v| [k, v] } || {}

# good
hsh.to_h { |k,v| [k, v] }

@koic
Copy link
Member Author

koic commented Nov 24, 2023

That case has already been addressed in this PR.

@koic
Copy link
Member Author

koic commented Nov 24, 2023

# bad
hsh&.to_h { |k, v| [k, v] } || {}

# good
hsh.to_h { |k,v| [k, v] }

That probably isn't the responsibility of this cop.

@ydakuka
Copy link

ydakuka commented Nov 24, 2023

Ok, I've created the issue.

@koic koic merged commit f466f86 into rubocop:master Nov 25, 2023
28 checks passed
@koic koic deleted the make_style_map_to_hash_aware_of_safe_navigation_operator branch November 25, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants