[Fix #12370] Make Style/HashEachMethods aware of unused block value
#12398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
reviewed
Nov 20, 2023
koic
force-pushed
the
make_hash_each_methods_aware_of_unused_block_value
branch
from
5ac7cac
to
23a6ba2
Compare
bbatsov
reviewed
Nov 20, 2023
| @@ -47,6 +47,40 @@ | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'does not register an offense when the value and value block arguments of `Enumerable#each` method are unused' do | |||
There was a problem hiding this comment.
value and value -> key are value
unused -> used
bbatsov
reviewed
Nov 20, 2023
| expect_no_offenses('foo.each { |k, v| do_something(k, v) }') | ||
| end | ||
|
|
||
| it 'does not register an offense when the single block argument of `Enumerable#each` method are unused' do |
bbatsov
reviewed
Nov 20, 2023
| expect_no_offenses('foo.each { |e| do_something(e) }') | ||
| end | ||
|
|
||
| it 'does not register an offense when the parenthesized value and value block arguments of `Enumerable#each` method are unused' do |
There was a problem hiding this comment.
value and value -> key and value
bbatsov
reviewed
Nov 20, 2023
| expect_no_offenses('foo.each { |(k, v)| do_something(e) }') | ||
| end | ||
|
|
||
| it 'registers an offense when the value block argument of `Enumerable#each` method are unused' do |
bbatsov
reviewed
Nov 20, 2023
| RUBY | ||
| end | ||
|
|
||
| it 'registers an offense when the key block argument of `Enumerable#each` method are unused' do |
koic
force-pushed
the
make_hash_each_methods_aware_of_unused_block_value
branch
from
23a6ba2
to
7813213
Compare
bbatsov
reviewed
Nov 20, 2023
| # | ||
| # # bad | ||
| # hash.values.each { |v| p v } | ||
| # hash.each.each { |unused_key, v| p v } |
There was a problem hiding this comment.
I think it should be just hash.each here.
…k value Fixes rubocop#12370. This PR makes `Style/HashEachMethods` aware of unused block value. And this PR suppresses the following new offense in this repository: ```console $ bundle exec rubocop --only Style/HashEachMethods -A (snip) Offenses: lib/rubocop/cop/style/bisected_attr_accessor.rb:36:11: C: [Corrected] Style/HashEachMethods: Use each_value instead of each, and remove the unused _visibility block argument. find_macros(class_node.body).each do |_visibility, macros| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1519 files inspected, 1 offense detected, 1 offense corrected ```
koic
force-pushed
the
make_hash_each_methods_aware_of_unused_block_value
branch
from
7813213
to
b42f1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12370.
This PR makes
Style/HashEachMethodsaware of unused block value. And this PR suppresses the following new offense in this repository:Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.